rkrtechnology/litestream
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update index & offset encoding

Browse Source 
Previously, the index & offsets were encoded as 8-character hex
strings, however, this limits the maximum value to a `uint32`. This
is normally not an issue, however, indices could go over the maximum
value of 4 billion over time and the offset could exceed this value
for an especially large WAL update. For safety, these encodings have
been updated to 16-character hex encodings.
This commit is contained in:
Ben Johnson
2022-02-08 12:49:36 -07:00
parent 54f3b94d3f
commit 006e4b7155
189 changed files with 203 additions and 197 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
replica_client_test.go
View File

@@ -19,7 +19,7 @@ func TestFindSnapshotForIndex(t *testing.T) {
if snapshotIndex, err := litestream.FindSnapshotForIndex(context.Background(), client, "0000000000000000", 0x000007d0); err != nil {
t.Fatal(err)
} else if got, want := snapshotIndex, 0x000003e8; got != want {
t.Fatalf("index=%08x, want %08x", got, want)
t.Fatalf("index=%s, want %s", litestream.FormatIndex(got), litestream.FormatIndex(want))
}
})
@@ -28,14 +28,14 @@ func TestFindSnapshotForIndex(t *testing.T) {
if snapshotIndex, err := litestream.FindSnapshotForIndex(context.Background(), client, "0000000000000000", 0x000003e8); err != nil {
t.Fatal(err)
} else if got, want := snapshotIndex, 0x000003e8; got != want {
t.Fatalf("index=%08x, want %08x", got, want)
t.Fatalf("index=%s, want %s", litestream.FormatIndex(got), litestream.FormatIndex(want))
}
})
t.Run("ErrNoSnapshotsBeforeIndex", func(t *testing.T) {
client := litestream.NewFileReplicaClient(filepath.Join("testdata", "find-snapshot-for-index", "no-snapshots-before-index"))
_, err := litestream.FindSnapshotForIndex(context.Background(), client, "0000000000000000", 0x000003e8)
if err == nil || err.Error() != `no snapshots available at or before index 000003e8` {
if err == nil || err.Error() != `no snapshots available at or before index 00000000000003e8` {
t.Fatalf("unexpected error: %#v", err)
}
})
@@ -499,7 +499,7 @@ func TestRestore(t *testing.T) {
client := litestream.NewFileReplicaClient(testDir)
if err := litestream.Restore(context.Background(), client, filepath.Join(tempDir, "db"), "0000000000000000", 0, 2, litestream.NewRestoreOptions()); err != nil {
t.Fatal(err)
} else if !fileEqual(t, filepath.Join(testDir, "00000002.db"), filepath.Join(tempDir, "db")) {
} else if !fileEqual(t, filepath.Join(testDir, "0000000000000002.db"), filepath.Join(tempDir, "db")) {
t.Fatalf("file mismatch")
}
})
@@ -511,7 +511,7 @@ func TestRestore(t *testing.T) {
client := litestream.NewFileReplicaClient(testDir)
if err := litestream.Restore(context.Background(), client, filepath.Join(tempDir, "db"), "0000000000000000", 0, 0, litestream.NewRestoreOptions()); err != nil {
t.Fatal(err)
} else if !fileEqual(t, filepath.Join(testDir, "00000000.db"), filepath.Join(tempDir, "db")) {
} else if !fileEqual(t, filepath.Join(testDir, "0000000000000000.db"), filepath.Join(tempDir, "db")) {
t.Fatalf("file mismatch")
}
})
@@ -525,7 +525,7 @@ func TestRestore(t *testing.T) {
opt.Parallelism = 0
if err := litestream.Restore(context.Background(), client, filepath.Join(tempDir, "db"), "0000000000000000", 0, 2, opt); err != nil {
t.Fatal(err)
} else if !fileEqual(t, filepath.Join(testDir, "00000002.db"), filepath.Join(tempDir, "db")) {
} else if !fileEqual(t, filepath.Join(testDir, "0000000000000002.db"), filepath.Join(tempDir, "db")) {
t.Fatalf("file mismatch")
}
})