From 5134bc3328691cccd115083a259e397fa7a6176c Mon Sep 17 00:00:00 2001
From: Ben Johnson <benbjohnson@yahoo.com>
Date: Fri, 1 Jan 2021 09:26:23 -0700
Subject: [PATCH] Add test coverage for DB.CRC64

---
 db.go      | 12 +++++++-----
 db_test.go | 42 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 49 insertions(+), 5 deletions(-)

diff --git a/db.go b/db.go
index e80e887..308aa46 100644
--- a/db.go
+++ b/db.go
@@ -77,12 +77,12 @@ type DB struct {
 	// better precision.
 	CheckpointInterval time.Duration
 
+	// Frequency at which to perform db sync.
+	MonitorInterval time.Duration
+
 	// List of replicas for the database.
 	// Must be set before calling Open().
 	Replicas []Replica
-
-	// Frequency at which to perform db sync.
-	MonitorInterval time.Duration
 }
 
 // NewDB returns a new instance of DB for a given path.
@@ -253,8 +253,10 @@ func (db *DB) Open() (err error) {
 	}
 
 	// Start monitoring SQLite database in a separate goroutine.
-	db.wg.Add(1)
-	go func() { defer db.wg.Done(); db.monitor() }()
+	if db.MonitorInterval > 0 {
+		db.wg.Add(1)
+		go func() { defer db.wg.Done(); db.monitor() }()
+	}
 
 	return nil
 }
diff --git a/db_test.go b/db_test.go
index f11875b..655abe7 100644
--- a/db_test.go
+++ b/db_test.go
@@ -109,6 +109,47 @@ func TestDB_UpdatedAt(t *testing.T) {
 	})
 }
 
+// Ensure we can compute a checksum on the real database.
+func TestDB_CRC64(t *testing.T) {
+	t.Run("ErrNotExist", func(t *testing.T) {
+		db := MustOpenDB(t)
+		defer MustCloseDB(t, db)
+		if _, _, err := db.CRC64(); !os.IsNotExist(err) {
+			t.Fatalf("unexpected error: %#v", err)
+		}
+	})
+
+	t.Run("DB", func(t *testing.T) {
+		db, sqldb := MustOpenDBs(t)
+		defer MustCloseDBs(t, db, sqldb)
+
+		chksum0, _, err := db.CRC64()
+		if err != nil {
+			t.Fatal(err)
+		}
+
+		// Issue change that is applied to the WAL. Checksum should not change.
+		if _, err := sqldb.Exec(`CREATE TABLE t (id INT);`); err != nil {
+			t.Fatal(err)
+		} else if chksum1, _, err := db.CRC64(); err != nil {
+			t.Fatal(err)
+		} else if chksum0 != chksum1 {
+			t.Fatal("expected equal checksum after WAL change")
+		}
+
+		// Checkpoint change into database. Checksum should change.
+		if _, err := sqldb.Exec(`PRAGMA wal_checkpoint(TRUNCATE);`); err != nil {
+			t.Fatal(err)
+		}
+
+		if chksum2, _, err := db.CRC64(); err != nil {
+			t.Fatal(err)
+		} else if chksum0 == chksum2 {
+			t.Fatal("expected different checksums after checkpoint")
+		}
+	})
+}
+
 // MustOpenDBs returns a new instance of a DB & associated SQL DB.
 func MustOpenDBs(tb testing.TB) (*litestream.DB, *sql.DB) {
 	db := MustOpenDB(tb)
@@ -127,6 +168,7 @@ func MustOpenDB(tb testing.TB) *litestream.DB {
 
 	dir := tb.TempDir()
 	db := litestream.NewDB(filepath.Join(dir, "db"))
+	db.MonitorInterval = 0 // disable background goroutine
 	if err := db.Open(); err != nil {
 		tb.Fatal(err)
 	}