From 896aef070c6c244a6bc222698d4ea76fd7dd4a67 Mon Sep 17 00:00:00 2001 From: Ben Johnson Date: Tue, 9 Mar 2021 15:38:32 -0700 Subject: [PATCH] Default region if endpoint specified --- s3/s3.go | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/s3/s3.go b/s3/s3.go index 3d3a95c..3fda9b7 100644 --- a/s3/s3.go +++ b/s3/s3.go @@ -732,9 +732,13 @@ func (r *Replica) Init(ctx context.Context) (err error) { // Endpoints are typically used for non-S3 object stores and do not // necessarily require a region. region := r.Region - if region == "" && r.Endpoint == "" { - if region, err = r.findBucketRegion(ctx, r.Bucket); err != nil { - return fmt.Errorf("cannot lookup bucket region: %w", err) + if region == "" { + if r.Endpoint == "" { + if region, err = r.findBucketRegion(ctx, r.Bucket); err != nil { + return fmt.Errorf("cannot lookup bucket region: %w", err) + } + } else { + region = "us-east-1" // default for non-S3 object stores } }